search

Yelp / nerve-tools

Tools for configuring SmartStack's Nerve based on local sources
Apache License 2.0
3 stars 12 forks source link

Write the deploy_group and paasta_instance to nerve config #55

Closed yannlandry closed 5 years ago

yannlandry commented 5 years ago

This is part 2 of CORESERV-7915 (internal ticket). The code here requires the changes I made in PaaSTA to work, that I released yesterday, before bumping the requirements to paasta-tools==0.84.19.

Again, added some optional data to be passed along with service registrations. If the data isn't there, it simply won't be written. Added extra fields to the testing logic and that's pretty much it.

yannlandry commented 5 years ago

Argh. Remnants of a debugging file. Removed now.

yannlandry commented 5 years ago

Don't think so. The point of the new test is to ensure the values are passed when they're there, otherwise nothing specific/different should happen. We'll pass either None values or no values at all.

bplotnick commented 5 years ago

Ok. I was simply asking whether there was existing coverage in other tests, but it looks like there is.