Remove v1 style nodes - Githubissues

Yelp / nerve-tools

Tools for configuring SmartStack's Nerve based on local sources

Apache License 2.0

3 stars 12 forks source link

Remove v1 style nodes #64

Closed kaisen closed 5 years ago

kaisen commented 5 years ago

This is the same as #25 with merge conflicts resolved.

Can this be merged now? I couldn't find anything that uses the v1 style nodes. This will help zookeeper from being overloaded when services are also registered through Envoy (see CORESERV-8573).

solarkennedy commented 5 years ago

@mattmb can you be primary on this? @kaisen In general I'm in favor of this cleanup. Be sure to do the standard gradual rollout though, it isn't super easy to be sure that these nodes are not actually in use.