search

Yelp / nerve-tools

Tools for configuring SmartStack's Nerve based on local sources
Apache License 2.0
3 stars 12 forks source link

Remove haproxy-synapse code and replace it with Envoy #91

Closed nemacysts closed 2 years ago

nemacysts commented 2 years ago

We no longer run Synapse at Yelp, so updown_service was broken since we correspondingly no longer run haproxy-synapse.

All we really care is whether the service we're updowning is in the mesh, so we can just check Envoy instead.

Rob-Johnson commented 2 years ago

do you want to write any tests?

nemacysts commented 2 years ago

do you want to write any tests?

@Rob-Johnson yea - planning on it (after fixing the build) :)

that said, I didn't want to block the team that needs this for too much longer if I run out of time today/it's taking a while (especially since I still need to figure out why the build is currently broken :p) so I was thinking I could release this and write tests immediately after...but it hopefully shouldn't take too long :p