Yelp / nerve-tools

Tools for configuring SmartStack's Nerve based on local sources
Apache License 2.0
3 stars 12 forks source link

Bump paasta-tools to 0.131.3 to get toggle to exclude terminated pods from configure_nerve #93

Closed jfongatyelp closed 2 years ago

jfongatyelp commented 2 years ago

https://github.com/Yelp/paasta/pull/3355 was deployed in version 0.131.3 and adds an option to control whether we include terminating pods in nerve config or not (status quo is to include terminating pods).

This change itself should not change any behavior, we will also have to disable the nerve_register_k8s_terminating toggle on the paasta system side (currently defaults to true).

EvanKrall commented 2 years ago

I think this PR would be obsoleted by #96

jfongatyelp commented 2 years ago

(Closed in lieu of #96 , thanks @EvanKrall )