search

Yelp / osxcollector_output_filters

Filters that process and transform the output of osxcollector
https://github.com/Yelp/osxcollector
Other
78 stars 11 forks source link

Created HtmlSummaryFilter class #23

Closed jjsendor closed 8 years ago

jjsendor commented 8 years ago

Closes #22.

0xdabbad00 commented 8 years ago

This will move us forward with this, but we should really be using a template engine to generate our HTML. This will help make this cleaner, and also currently we're at risk of XSS and similar issues, which isn't that much of a threat for our use case, but could be annoying and could be more problematic for other people's use cases. For our use case, we might just have an attacker that names things in such a way that it results in malicious javascript that hides their badness, which would be dumb because someone so dedicated should instead just try to hide from our collection, but anyway, it's a concern. Again though, a template engine would make this code much prettier.

jjsendor commented 8 years ago

Great suggestion! I will explore if there is some easy way to embed templating there. Also for styling, or any dynamic content (e.g. expanding lists by clicking) I would need to check if it is possible to include something that will still produce just a single HTML file as having external resources for this page would be a lot of pain when it comes to generating the summary and then opening it.