Issue150 force termination upon pgctl stop/restart

Yelp / pgctl

Manage sets of developer services -- "playground control"

http://pgctl.rtfd.org

MIT License

32 stars 15 forks source link

Issue150 force termination upon pgctl stop/restart #181

Closed yalinhuang closed 7 years ago

yalinhuang commented 7 years ago

The CircleCI test failure seems flaky :( I invoked a build on my local branch, and the tests pass while the coverage fails.

bukzor commented 7 years ago

@smallredbean: Great work! It's ready to ship as far as I can see.

As long as you show that the test suite can pass, that's good enough for me. There's a known flakiness with pytest-xdist (multiprocessing) and coverage, but I thought @0xngold turned off parallelism during CI.

Ship It! :ship:

yalinhuang commented 7 years ago

One question arises...

While the current "--force" option only kills runaway processes (processes running away from their s6 supervisors, which have died), should we consider killing slow-responding processes? These processes take longer than expected to react to pgctl stop but they are still under a s6 supervisor. That is, after pgctl stop yelling "ERROR: service 'foo' failed to stop after bar seconds", pgctl status shows foo in ready state.

I'd vote for cleaning them up.

bukzor commented 7 years ago

shipit