search

Yelp / pgctl

Manage sets of developer services -- "playground control"
http://pgctl.rtfd.org
MIT License
32 stars 15 forks source link

pgctl-poll-ready should either support cwd changes before it's exec'd, or warn when that happens #202

Open chriskuehl opened 7 years ago

chriskuehl commented 7 years ago

@magicmark was debugging a weird issue where pgctl-poll-ready was very flaky. It ended up being because he was changing directories in his script before calling pgctl-poll-ready, and then it was looking in the wrong place for the notification-fd file.

The errors looked like:

2017-08-30 12:54:23.427834500  Traceback (most recent call last):
2017-08-30 12:54:23.427850500    File "/nail/home/markl/pg/react_component_renderer/venv/bin/pgctl-poll-ready", line 11, in <module>
2017-08-30 12:54:23.427852500      sys.exit(main())
2017-08-30 12:54:23.427853500    File "/nail/home/markl/pg/react_component_renderer/venv/lib/python3.6/site-packages/pgctl/poll_ready.py", line 106, in main
2017-08-30 12:54:23.427855500      notification_fd = int(floatfile('notification-fd'))
2017-08-30 12:54:23.427856500    File "/nail/home/markl/pg/react_component_renderer/venv/lib/python3.6/site-packages/pgctl/poll_ready.py", line 22, in floatfile
2017-08-30 12:54:23.427858500      with open(filename) as f:
2017-08-30 12:54:23.427859500  FileNotFoundError: [Errno 2] No such file or directory: 'notification-fd'

It's probably possible to either allow this or detect it, and would reduce confusion quite a bit.