search

Yelp / pgctl

Manage sets of developer services -- "playground control"
http://pgctl.rtfd.org
MIT License
32 stars 15 forks source link

Add an embedded log viewer during start/stop #220

Closed chriskuehl closed 3 years ago

chriskuehl commented 3 years ago

This adds an embedded log viewer during pgctl start and pgctl stop which tails the logs of the services being started or stopped. The idea is to help users understand what is going on when pgctl takes a long time to start or stop things.

It looks like this:

https://user-images.githubusercontent.com/665269/140195366-dc4e135f-7fee-4c21-a88e-5aa511fc8b7a.mov

There is some concern that all the new output may be confusing to users or make them think something is wrong. I tried to adjust the output a bit to improve this, but there is surely future room for improvement.

It is enabled by default but can be disabled via config option (per-project, per-user, or per-host), so we can turn it off if it causes problems.

chriskuehl commented 3 years ago

This is essentially working with no known bugs remaining, just need to get some reviews on the UX before I go fix all of the tests (they're mostly broken due to slight changes in output).