search

Yelp / pyleus

Pyleus is a Python framework for developing and launching Storm topologies.
Apache License 2.0
404 stars 113 forks source link

Added trusted host argument to pip when running local pypi server #134

Closed mzbyszynski closed 9 years ago

mzbyszynski commented 9 years ago

Fixes #133

mzbyszynski commented 9 years ago

Oops, looks like I broke a unit test. I'll fix that shortly.

imcom commented 9 years ago

this patch is essential for building and testing pyleus on development stage

poros commented 9 years ago

+1 That's a very good point! I use an older version of pip, so I never noticed it.

poros commented 9 years ago

Giving a second thought to it, it should possible to specify the same option in your pip.conf file and get away with it, without forcing pylues to do that for you.

I do not have a strong preference, but I am wondering if this change might break for old pip versions.

mzbyszynski commented 9 years ago

I think older versions pip just ignore the argument, but I'll try and confirm tonight or tomorrow.

mzbyszynski commented 9 years ago

Actually @poros you are right about the older versions of pip.. they barf on that argument. I think your pip.conf idea is a good solution. Maybe there just needs to be some note on the contributing page of the documentation that describes how to do this if you are using pip 7 or whatever version added the new trusted-host parameter?

poros commented 9 years ago

Thank you for trying that out. Yes, a tip in the documentation is the best solution. Do you want to change this PR to do that so you get at least one commit with your name on it? Otherwise I'll do that as soon as I have some spare time.

mzbyszynski commented 9 years ago

No need to wait for me. If I manage to get the pip.conf to work in my environment I'll write something up, if you don't get to it first.

Thanks!