Yelp / pyleus

Pyleus is a Python framework for developing and launching Storm topologies.
Apache License 2.0
404 stars 113 forks source link

Add configuration option for brokerZkPath in Kafka Spouts #137

Closed MelvinRoss closed 9 years ago

MelvinRoss commented 9 years ago

This should address the issue in https://github.com/Yelp/pyleus/issues/124 . It builds on the fix offered in https://github.com/Yelp/pyleus/pull/128 and provides a yaml config option for the broker zookeeper path. The config option is 'broker_zk_path'. The means of these configuration options can be found at https://github.com/apache/storm/tree/master/external/storm-kafka#zkhosts

jwestboston commented 9 years ago

I've tested this with Storm 0.9.4 and Pyleus 0.3.0 and it is working. Excellent. Thank you @MelvinRoss

poros commented 9 years ago

That's it! Thank you very much for contributing! :)