search

Yelp / pyleus

Pyleus is a Python framework for developing and launching Storm topologies.
Apache License 2.0
404 stars 113 forks source link

Contribute MessagePackSerializer upstream #159

Open dan-blanchard opened 8 years ago

dan-blanchard commented 8 years ago

Your MessagePackSerializer class seems like it would be broadly useful in the Storm community. Would you be willing to contribute it to Apache Storm proper? It's already Apache license, and obviously so is their code.

dan-blanchard commented 8 years ago

I don't mean to step on any toes here, but since this is so broadly useful and the licenses are compatible, I was planning on trying to get this file added upstream. I would prefer to have the :ok_hand: from you all first, but in the end it's all just compatible open source code.

patricklucas commented 8 years ago

Yes, of course! Sincere apologies for missing this question from October, thanks to @poros for pinging me about it.

I'm totally on board with sending this upstream, though I'd like to get +1s from @ecanzonieri and @poros as well.

dan-blanchard commented 8 years ago

Coincidentally, it looks like someone has a slightly different serializer implementation they just opened a PR for, so I'm sure your input on their PR would be very valuable. It's apache/storm#1136.