Depend on simplejson for Python < 2.7

Yelp / pyleus

Pyleus is a Python framework for developing and launching Storm topologies.

Apache License 2.0

404 stars 113 forks source link

Depend on simplejson for Python < 2.7 #47

Open patricklucas opened 9 years ago

patricklucas commented 9 years ago

This adds a dependency on simplejson for Python < 2.7 and moves the stanza to import the appropriate json module into pyleus.compat.

Closes #46

poros commented 9 years ago

Mmm, why Travis' build status is missing on this request?

patricklucas commented 9 years ago

Because Travis misses some PRs for some reason. :/

I'm going to modulate this branch to "just" move the try/except into compat.py for now.

sontek commented 9 years ago

@poros This has mereg conflicts, can you fix it up?

poros commented 9 years ago

My concerns about json vs simplejson performances in Python 2.7 are actually fading out. If @plucas is up for it, we may want to unblock this pull request and go ahead with the merge.