Yelp / pyleus

Pyleus is a Python framework for developing and launching Storm topologies.
Apache License 2.0
404 stars 113 forks source link

'pyleus build -s' will remove local pyleus-base.jar #74

Closed William-Sang closed 9 years ago

William-Sang commented 9 years ago

When run pyleus build -s xxxx/pyleus_topology.yaml once, then pyleus-base.jar will be removed.

Rerun pyleus build, it will show

pyleus build: error: [JarError] Base jar not found
poros commented 9 years ago

Thank you for let us know. The build script somehow tries to remove the base jar when run with the system-site-packages option. I got this traceback:

[antonio@dev9-devc:~/dev/oss/poros] :) $ pyleus build -s pyleus/examples/word_count/pyleus_topology.yaml
Traceback (most recent call last):
  File "/usr/bin/pyleus", line 6, in <module>
    main()
  File "/usr/lib/python2.6/dist-packages/pyleus/cli/cli.py", line 52, in main
    args.func(args)
  File "/usr/lib/python2.6/dist-packages/pyleus/cli/commands/subcommand.py", line 105, in run_subcommand
    self.run(configs)
  File "/usr/lib/python2.6/dist-packages/pyleus/cli/commands/build_subcommand.py", line 40, in run
    build_topology_jar(configs)
  File "/usr/lib/python2.6/dist-packages/pyleus/cli/build.py", line 274, in build_topology_jar
    verbose=configs.verbose,
  File "/usr/lib/python2.6/dist-packages/pyleus/cli/build.py", line 202, in _create_pyleus_jar
    verbose=verbose)
  File "/usr/lib/python2.6/dist-packages/pyleus/cli/build.py", line 108, in _set_up_virtualenv
    _remove_pyleus_base_jar(venv)
  File "/usr/lib/python2.6/dist-packages/pyleus/cli/build.py", line 82, in _remove_pyleus_base_jar
    os.remove(base_jar_path)
OSError: [Errno 13] Permission denied: '/usr/lib/python2.6/dist-packages/pyleus/pyleus-base.jar'

While we work on the issue, you should be able to pyleus build successfully if you avoid using the -s option.

William-Sang commented 9 years ago

@poros Thinks for replying. I'm looking forward to the next release. Because without option '-s' , it will be really slow to build the project. I take option '-s' as a way to reuse system's package, then we don't need download dependency packages again. I don't know whether it's right or not. We really appreciate your affords.

poros commented 9 years ago

Closed by #78. It should be out with next release.