Closed mzbyszynski closed 9 years ago
looks good to me. thanks for contributing.
It seems legit to me. However, we do not have tests covering that part and I can't run an actual kafka topology in the next days to try it out, sorry. So +1 if someone else confirmed it worked for him.
I would prefer a test over manual but I have kafka running so I can test as well
@sontek: you are right, automatic testing would be a way better method, but the java bits are totally lacking from that point of view. For now manual testing is necessary.
I really appreciate your help, thank you :)
Fixes ClassCastException when the yaml parser identifies the start_offset_time setting for a KafkaSpout as an Integer instead of a Long. Also fixes a NullPointerException when start_offset_time is not defined in the topology yaml for a KafkaSpout (since you can't cast a
null
to aLong
).Closes #93