Closed jswetzen closed 9 years ago
Would you mind adding some unit tests to cover your changes (you are free to modify existing ones, if you believe it is the case)? tests/storm/bolt_test.py is the right file for that.
The test for SimpleBolt was simple to write but Bolt was harder to write beautifully as there is no fixture there. The alternatives I thought of were:
That worked well. It's not longer than the nested wheres would be but to me it's easier to read.
+1 Looks good to me I believe that this change is backward compatible, so we can merge it even if pyleus is not Storm 0.9.3 ready. Edit: I tried both locally and remotely the word_count topology with Storm 0.9.2 and it worked fine.
+1 going to merge this one
As @tdihp was okay with it, here is his code with some fixes that adds heartbeat to both Bolt and SimpleBolt but without ack afterwards.