make the datacenter unique by providing environment info

Yelp / sensu_handlers

Custom Sensu Handlers to support a multi-tenant environment, allowing checks themselves to emit the type of handler behavior they need in the event json

Apache License 2.0

75 stars 31 forks source link

make the datacenter unique by providing environment info #101

Closed cabecada closed 8 years ago

cabecada commented 8 years ago

the earlier PR provided datacenter key in incident key of pagerduty but updating datacenter to arbitary value broke the uchiwa dashboard link. this PR would ensure all dashboard link work well as well pagerduty incident key remains unique for environment/region combination

cabecada commented 8 years ago

@solarkennedy @somic can you please merge this PR

solarkennedy commented 8 years ago

I don't quite understand, why would setting datacenter to an arbitrary value break uchiwa? Why not the datacenter to the same value that "datacenter" is set in uchiwa?

cabecada commented 8 years ago

first of all, happy thanksgiving :) i did not know you would work today.

Thanks for asking. i figured out our "uchiwa" endpoint had names(datacenters list) hardcoded to "usw2/usw1" via hiera, whereas dashboard datacenter managed via puppet, hence the mismatch.

i guess i totally forgot about hiera providing uchiwa endpoints :) Thanks for pointing it out.