Yelp / sensu_handlers

Custom Sensu Handlers to support a multi-tenant environment, allowing checks themselves to emit the type of handler behavior they need in the event json
Apache License 2.0
75 stars 31 forks source link

plans for sensu core filtering support? #102

Open cabecada opened 7 years ago

cabecada commented 7 years ago

Sensu 0.26 and later have started deprecating use of filtering at handler and use core inbuilt filtering. Are there any plans to support for sensu 0.26+ for the above changes ? :)

solarkennedy commented 7 years ago

Not yet :(

I am in favor of Sensu's change in general, but you are right that it does mean a substantial change to these handlers, and I haven't scoped out how well address that yet.

cabecada commented 7 years ago

they have support for filtering via extensions https://github.com/sensu-extensions/sensu-extensions-occurrences

I can give it a try, and raise a PR, but i guess that might break <0.26 sensu support via sensu_handler ?

cabecada commented 7 years ago

i tested it out like this, https://gist.github.com/cabecada/3bd548a3cb5e3415a8fed30b276d2409

if this is fine, we have an official extension for that functionality and that would unblock ppl who are using this handler :)

somic commented 7 years ago

1.0 is out - https://blog.sensuapp.org/sensu-core-version-1-0-is-now-available-c93b61977933

So far I see a lot of features and complexity that we are not using.