search

Yelp / sensu_handlers

Custom Sensu Handlers to support a multi-tenant environment, allowing checks themselves to emit the type of handler behavior they need in the event json
Apache License 2.0
75 stars 31 forks source link

Fixing the ruby-mail package dependency for Debian #56

Closed liamjbennett closed 9 years ago

solarkennedy commented 9 years ago

We use Ubuntu, so maybe we are just behind on packages.

I don't really like all this pinning inside, it makes it difficult for other people to use (hence the PR)

Instead can you make it a class param and just default to latest, and then on our side we can pin back to whatever version we need? (via hiera)

fessyfoo commented 9 years ago

where does the rubygem-mail package come from? AFAICT it wasn't in any release of ubuntu.

http://packages.ubuntu.com/search?suite=trusty&section=all&arch=any&keywords=rubygem-mail&searchon=names

does Yelp have it's own deb packaging of ruby gems?

solarkennedy commented 9 years ago

Yea, I think I may have just fpm -s gem -t deb mail.

Looks like the tests are failing, but probably from a different reason. Can you merge master to make sure it is running up against the latest fixtures?

fessyfoo commented 9 years ago

master currently fails to pass tests. the latest monitoring_check requires a newer version of sensu_check which is pinned to an older version in the .fixtures file.

liamjbennett commented 9 years ago

Closing in favor of #60