search

Yelp / swagger-spec-compatibility

Python library to check Swagger Spec backward compatibility
https://swagger-spec-compatibility.readthedocs.org
Apache License 2.0
20 stars 8 forks source link

swagger-spec-compatibility is not compatible with bravado-core==5.16.0 #18

Closed macisamuele closed 4 years ago

macisamuele commented 4 years ago

As highlighted by @garyhoren, using a fresh install of swagger-spec-compatibility raises

TypeError: unhashable type: 'Spec'

This is caused because the latest bravado-core version (5.16.0) has changed the hashability propery of bravado_core.spec.Spec instances. More details are available on https://github.com/Yelp/bravado-core/pull/363.

In order to limit the bleeding of the issue, I'm updating the requirements of the package by highlighting the incompatibility by blacklisting version 5.16.0 of bravado-core.

This PR will fix the tests of the package, that are currently red

codecov[bot] commented 4 years ago

Codecov Report

Merging #18 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #18   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          60     60           
  Lines        1891   1891           
  Branches      121    121           
=====================================
  Hits         1891   1891

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6342b72...a9dcb60. Read the comment docs.