search

Yelp / swagger-spec-compatibility

Python library to check Swagger Spec backward compatibility
https://swagger-spec-compatibility.readthedocs.org
Apache License 2.0
20 stars 8 forks source link

add new rule for detecting change of additionalProperties from True to False #32

Closed phoebey01 closed 4 years ago

phoebey01 commented 4 years ago

This PR fixes #4 by implementing a new rule. Added tests and documentation.

phoebey01 commented 4 years ago

It's currently failing Travis CI builds for python2.7. Do you know how I could fix this? @macisamuele

macisamuele commented 4 years ago

@yyang08 I'll be reviewing this PR either today or tomorrow. Sorry for the long turnaround

About the test failures, I revamped #30 that fixed tests on all the environments ... so I would not be very concerned for now

phoebey01 commented 4 years ago

@macisamuele Thanks for the review. I've updated the doc per your suggestion. Glad to contribute - it's a great tool and my company is adopting it for service API development.

macisamuele commented 4 years ago

Merging this as tests are green on my local machine. Fixing the CI is addressed by #30 (but we're waiting for some final agreements).