search

Yelp / swagger_spec_validator

Other
104 stars 71 forks source link

Fix test_complicated_refs broken after jsonschema-validator 3.0.0 #117

Closed macisamuele closed 5 years ago

macisamuele commented 5 years ago

Checking #116 I did noticed that our build was failing. The failure has been caused by the release of jsonschema-validator v3.0.0.

The failing test is failing because the new version of the validator adds support for jsonschema draft6 and draft7 (which are stored into the resolver.store). The test was verifying that all the expected file:// references were loaded by the resolver but in doing it the test was keeping into account the 2 http:// references (draft3 and draft4).

In order to fix the test and make it more stable for future versions of jsonschema-validator I modified the test to only care about the file:// references

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 98.526% when pulling 9efc14ea8b1dbb21da2c61a6023807b1d0774bbc on macisamuele:maci-fix-tests-failures into 0ffe7b83e6467381ead6c1107d08cf921f0a1f47 on Yelp:master.