Yelp / swagger_spec_validator

Other
104 stars 71 forks source link

perf: use cache instead of reloading schema files #132

Closed brycedrennan closed 4 years ago

brycedrennan commented 4 years ago

I botched the previous PR by deleting my fork. Apologies.

Feedback is all addressed from #131

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.4%) to 98.542% when pulling d899b7421a5cdb6d9414d533624ad06943fa0e91 on brycedrennan:perf-fixes into 1c1b5736a00e5e21d654202812d1885729829486 on Yelp:master.

brycedrennan commented 4 years ago

I left a separate commit so you could see the changes, but will rebase into one commit once we're on the same page.

brycedrennan commented 4 years ago

@macisamuele feedback addressed.

macisamuele commented 4 years ago

Considering that today is Friday (and generally is not a good idea to release when you're not around) I'll merge this on Monday and take care of releasing a new version

macisamuele commented 4 years ago

Released on 2.6.0