search

Yelp / swagger_spec_validator

Other
104 stars 71 forks source link

Use iteritems from six #146

Closed mangin closed 3 years ago

mangin commented 3 years ago

Hi there, swagger_spec_validator uses compat module from jsonschema. Jsonschema team removed this module in 4.X.X: https://github.com/Julian/jsonschema/commit/1d7711702f8b5f5396f4317d2a409fcf901ab8d3#diff-cdc6b1a8a01e77eecdfa0d2559447e4ca46a014edaab1f604db31db783fed8bc

It looks like that they are going to get rid of python2.7.

ATRAN2 commented 3 years ago

Whoops, I did this same fix just now trying to resolve a broken build I'll merge this PR anyway though

txels commented 2 years ago

Thanks for this fix! I see this has been tagged as 2.7.4 but not released to PyPI yet. I'd be super grateful if you could release it. Anything holding this up we could help you with?

macisamuele commented 2 years ago

@ATRAN2 can you look into it? I see that there is an automated pipeline to publish the new version on PyPi but I see that it failed to run due to some authentication issues. Is it possible that secrets.pypi_password is not properly configured?

https://github.com/Yelp/swagger_spec_validator/runs/3844523936