search

Yelp / swagger_spec_validator

Other
104 stars 71 forks source link

Add yaml support. #52

Closed EvgeneOskin closed 7 years ago

sjaensch commented 8 years ago

Hi @EvgeneOskin, thank you for your contribution! Currently the build is red, will you be fixing it? That would be awesome. Also, there might be issues with specs in the yaml format that don't quote the response status code (#49). You might want to add a workaround similar to what was done for bravado.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.4%) to 93.312% when pulling bde2ceee47f849edd2d8c797b626beb91c34e309 on EvgeneOskin:feature/add-yml-support into 8810da3922f988b93542fb3a8b82d75843be4a6a on Yelp:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+2.7%) to 96.497% when pulling 873a4892f04fe738464d07a79885feed8d5e5dd1 on EvgeneOskin:feature/add-yml-support into 8810da3922f988b93542fb3a8b82d75843be4a6a on Yelp:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+4.02%) to 97.771% when pulling 6a9da024b397694a8ddc0b929c6d9d7f72f09acc on EvgeneOskin:feature/add-yml-support into 8810da3922f988b93542fb3a8b82d75843be4a6a on Yelp:master.

EvgeneOskin commented 8 years ago

Hi @sjaensch, thank you for review and notes, I've fixed the build. Add simple test to load yml and json data. Also, I've fixed paths in validator12.run_test. At the moment, the build fails only in doc environment.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+4.02%) to 97.771% when pulling e795184b86469e027eab632a52e20ddbd8504892 on EvgeneOskin:feature/add-yml-support into 8810da3922f988b93542fb3a8b82d75843be4a6a on Yelp:master.

larsbutler commented 8 years ago

@EvgeneOskin @sjaensch This branch appears to just need a rebase on the latest master, due to https://github.com/Yelp/swagger_spec_validator/commit/a4669b8dd05391fdb528d90af974b7ee7a003f6f. After that, it should work.

EvgeneOskin commented 8 years ago

Thank @larsbutler

larsbutler commented 7 years ago

@EvgeneOskin @sjaensch Hmmm, something seems to be stuck with coveralls. The check is still pending. It'd be great to get this patch in; I would use it right away. :)