swagger-spec-validator is a pure python library

Yelp / swagger_spec_validator

Other

104 stars 71 forks source link

swagger-spec-validator is a pure python library #64

Closed asottile closed 7 years ago

coveralls commented 7 years ago

Coverage remained the same at 93.75% when pulling eada2c89554961bce650a6fb364f43e57ec56587 on asottile:patch-1 into 634aadcd8f73c32beba75f91d871b1bb6df2a5b2 on Yelp:master.

macisamuele commented 7 years ago

@asottile thanks for updating it. I would ask to to fix within this PR (if possible) the issue with python 2.6. Basically jsonschema 2.6.0 drops support for python2.6, since for the moment we would not remove the python 2.6 support could you add a workaround for that? An idea could be something similar to

'jsonschema' if sys.version_info[:2] >= (2, 7) else 'jsonschema<2.6.0'

asottile commented 7 years ago

In no way is that related to this branch, why are you making me fix your bitrot?

coveralls commented 7 years ago

Coverage remained the same at 93.75% when pulling dc57cc65f94d5345a28b8947ee06da02d725d0dc on asottile:patch-1 into 634aadcd8f73c32beba75f91d871b1bb6df2a5b2 on Yelp:master.

coveralls commented 7 years ago

Coverage remained the same at 93.75% when pulling dc57cc65f94d5345a28b8947ee06da02d725d0dc on asottile:patch-1 into 634aadcd8f73c32beba75f91d871b1bb6df2a5b2 on Yelp:master.

coveralls commented 7 years ago

Coverage remained the same at 93.75% when pulling dc57cc65f94d5345a28b8947ee06da02d725d0dc on asottile:patch-1 into 634aadcd8f73c32beba75f91d871b1bb6df2a5b2 on Yelp:master.

macisamuele commented 7 years ago

It was to avoid to open an additional PR for this. Dropping Python2.6 support seems also a good solution 😄 🚢

asottile commented 7 years ago

Merge?