search

Yelp / swagger_spec_validator

Other
104 stars 71 forks source link

Validator does not check uniqueness of operation ids #85

Closed ngaya-ll closed 3 years ago

ngaya-ll commented 6 years ago

According to the Swagger spec, the operationId of an operation object is:

Unique string used to identify the operation. The id MUST be unique among all operations described in the API. Tools and libraries MAY use the operationId to uniquely identify an operation, therefore, it is recommended to follow common programming naming conventions.

The validator does not currently check that operationIds are unique across the API. This would be a helpful feature because some codegen tools fail if this constraint is not met.

bradj commented 6 years ago

Just confirmed that this is still an issue.

macisamuele commented 6 years ago

The merged PR does not completely address the duplicate operation id issue as it ensures that no duplicate operation ids are present on the same tag.

mattmetlis commented 3 years ago

Is anyone able to look at this PR? I believe it addresses the rest of the issue.

mattmetlis commented 3 years ago

@analogue @sjaensch It looks like you are some of the most recent people who have merged pull requests in this project (if I'm reading the network graph correctly). Could you please take a look at this, or is there another maintainer you know of who can? This PR has a fix that's important for my company, and I haven't gotten any response on it since I submitted it more than a week ago.

sjaensch commented 3 years ago

@mattmetlis I don't have write access to the repository anymore, @analogue might be able to help out though.

mattmetlis commented 3 years ago

Is there anyone else you know of who has write access? This is looking like an abandoned project.