search

Yelp / terraform-provider-signalform

SignalForm is a terraform provider to codify SignalFx detectors, charts and dashboards
Apache License 2.0
44 stars 26 forks source link

Suggestion: Docker build #13

Closed jfharden closed 6 years ago

jfharden commented 6 years ago

Before I do the work to implement it I wondered if you would be open to me providing a PR which adds a Dockerfile to this project to allow building in a docker container instead of needing build tools installed locally?

I would also propose to add a make docker target which will run the necessary docker commands to build the provider.

poros commented 6 years ago

I am sorry, I am a bit confused. The project already supports the project to be built inside Docker; the Dockerfile is in the build folder. To run it either use make package or make itest_DISTRO (lucid, trusty and xenial are supported)

jfharden commented 6 years ago

Gah sorry! Long day and somehow I totally missed that. Thanks for the great provider anywho.