Minor fixes - Githubissues

Yelp / terraform-provider-signalform

SignalForm is a terraform provider to codify SignalFx detectors, charts and dashboards

Apache License 2.0

44 stars 26 forks source link

Minor fixes #21

Closed sjung-stripe closed 6 years ago

sjung-stripe commented 6 years ago

get the Makefile envars from go env so that osx users don't have to manually set them when running make
timeout test was flaking (actually it fails consistently on my workstation), this removes the flakiness

sjung-stripe commented 6 years ago

new push that deletes the timeout test

sjung-stripe commented 6 years ago

added another commit to this PR for an issue I encountered today: if you make test in a terminal with SFX_AUTH_TOKEN set, the test code will load the auth token from that environment variable, and then TestProviderConfigureFromNothing (which expects the auth token to be unset) will fail. A few different ways we could fix this, but I chose the easiest one, which is to just take the token out in the makefile.

dichiarafrancesco commented 6 years ago

lgtm!