Closed rahulravindran0108 closed 6 years ago
If we want terraform to be notified of these changes we need to add it to the resource rule hash, please keep the sorting order in mind so we have a consistent hash value. It would be great if you could update the unit tests as well.
Also, we need to read teams and tags resource properties and add them to the payload we send to SignalFx.
@kokje I have included the new parameters in the computation of resource hash. Added another test case and ensured that hash value for the previous test case remains consistent. I am guessing this will ensure that terraform does not update all the resources after this change goes through ?
Further, included teams and tags to the payload.
Can you please update the documentation accordingly. At a first glance, the change looks fine.
:shipit:
Closes #3
SignalFx supports new parameters in their rules and detector model. These parameters help in defining custom alert messages and also support adding tags and team-ids to detector.
https://developers.signalfx.com/v2/reference#detector-model
Testing
make test
passes.