Update detector model to use runbookUrl and tip params.

Yelp / terraform-provider-signalform

SignalForm is a terraform provider to codify SignalFx detectors, charts and dashboards

Apache License 2.0

44 stars 26 forks source link

Update detector model to use runbookUrl and tip params. #6

Closed rahulravindran0108 closed 6 years ago

rahulravindran0108 commented 6 years ago

Summary Detector model now supports creation of detectors with runbookUrl and tip. For reference, see https://developers.signalfx.com/reference#detector-model. Added documentation and test case to ensure the changes work.

Testing done make test passes.

kokje commented 6 years ago

lgtm! as long as we've verified that passing any combination of those 4 optional values is valid for Signalfx :shipit: