search

Yelp / zygote

A Python HTTP process management utility.
http://opensource.yelp.com/
Apache License 2.0
40 stars 15 forks source link

Make the logger *not* suppress output just because there is no TTY #63

Closed solarkennedy closed 9 years ago

solarkennedy commented 9 years ago

I think that detecting the absence of a tty and suppressing all output is surprising.

What if you are running under systemd or upstart and you want to redirect stder/out? What if you are in docker? What if you are running it in jenkins?

Plenty of things don't have a tty but that doesn't mean you don't want a logger.

(internal yelp ticket PAASTA-844) cc @EvanKrall @mrtyler

mrtyler commented 9 years ago

Travis build failed!

How sure are we that this won't cause any harm? Like if zygote tries to log with no tty available, does it blow up (in a likely hard-to-detect way because lol zygote logging)?

asottile commented 9 years ago

heh, travis failed because there is no .travis.yml hooked up for this project

solarkennedy commented 9 years ago

So.... dare me to ship this?

mrtyler commented 9 years ago

sure, why not

solarkennedy commented 9 years ago

Can someone else merge this? I don't have permission on this repo.

mrtyler commented 9 years ago

Done.