Yen / PSRT.Astra

PSO2 Patcher optimised for performance and stability
MIT License
21 stars 4 forks source link

Patcher thinks my game files are outdated despite it already being updated via other sources. #16

Closed Aorimiku closed 5 years ago

Aorimiku commented 5 years ago

Trying to use the patcher with an already updated version of PSO2 forces it to queue 71k files to download because they are "outdated" (screenshot).

An option to force the patcher to skip the file check and label the current files as "updated" would solve the issue.

This is my first time submitting an issue here so sorry if I'm doing something wrong.

Yen commented 5 years ago

Hey, thanks for the issue.

Astra is not actually downloading files here. I think I need to change the wording here but Astra is just calculating the hashes of the files to check them compared to what should be there. Only files that are actually outdated ever get downloaded.

This only happens on a large scale like this on your first use of Astra on a new PSO2 installation.

I hesitate to change this behaviour as its the only real way I can be sure that Astra can keep your game in a non corrupted state, the application trusts these calculations fully.

Changing the wording from "updating" is something I am up for if someone can propose a wording that can be used in the case for both scanning like you have here, but for also when you are actually updating the game. At this time I don't know of any way for Astra to tell these two operations apart because they are actually the same thing, so a word that can be used for both would be required.

Aorimiku commented 5 years ago

Astra is just calculating the hashes of the files to check them compared to what should be there.

Thanks for the clarification! Guess I was just mistaken here.

I don't know of any way for Astra to tell these two operations apart because they are actually the same thing, so a word that can be used for both would be required.

I'm honestly not good at wording things myself so I can't help with that. Maybe you could mention in the Readme that "updating" files isn't the same as "downloading" files.

Yen commented 5 years ago

Yeah, because we are now skipping the selection of the installation when the user restarts the application with a saved install path, I am considering showing a message box when the user selects a install location period. Just a little something that explains what its doing. In practice most users should only see this once and if they do see it again because they changed where they want their PSO2 install to live, its just a message box.

Gonna leave this open until I get round to that or someone else has a better idea.

Yen commented 5 years ago

Fixed by ce1b5032a12b21237b90b139130aba061eff7ebe