YeoLab / containers

Collection of Dockerfiles
0 stars 1 forks source link

update base notebook to hub-2.2.2 #4

Closed rpwagner closed 2 years ago

rpwagner commented 2 years ago

Builds, but not tested

@byee4 can you find out if bento-tools can support Python 3.10? I believe the developer is in your group.

byee4 commented 2 years ago

Sure, I think he's testing it now. Should have an answer by tomorrow

byee4 commented 2 years ago

I think one of bento's dependencies hasn't been updated: https://github.com/ckmah/bento-tools/runs/7116902834?check_suite_focus=true#step:4:99

He's taking a look right now, but alternatively, would another option be to use a conda py39 environment?

rpwagner commented 2 years ago

Bento has astropy pinned at 4.9.*, but there's a 5.0 release. Can you ask him to try the more recent version of astropy?

rpwagner commented 2 years ago

I put some time into trying to sort out the dependencies to try and get Bento to work with Python 3.10. In short, I'll look at what version of the hub and notebook servers we can run at Python 3.9 as you suggested.

If Clarence is open for input, I'd suggest that he looks at a few things to make his code more portable across environments and able to be installed alongside other packages. This is natural step when releasing code from a personal development environment to the community:

byee4 commented 2 years ago

Oh, awesome. Thanks! I’ll forward to Clarence. Right now, I do see an open PR for python3.10 compatibility, so if bento is the only package that requires 3.9 still, there may still be hope to get the version bumped to 3.10.

SECURE: MESSAGE FROM Rick Wagner ON 6/29/22, 1:23 PM

I put some time into trying to sort out the dependencies to try and get Bento to work with Python 3.10. In short, I'll look at what version of the hub and notebook servers we can run at Python 3.9 as you suggested.

If Clarence is open for input, I'd suggest that he looks at a few things to make his code more portable across environments and able to be installed alongside other packages. This is natural step when releasing code from a personal development environment to the community:

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/YeoLab/containers/pull/4*issuecomment-1170457982__;Iw!!LLK065n_VXAQ!i1jobe7Q5dmNbE1QyDzWlsgSngfEFFVI79JhplH3HW_1DgFWRjW055iW2GFYPyV7vs60yXfoCbkS2bZA83DG1L2tGcbU$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AB7TJPYWUZBD65X4GEM6Y4LVRSWDPANCNFSM52EAYAAA__;!!LLK065n_VXAQ!i1jobe7Q5dmNbE1QyDzWlsgSngfEFFVI79JhplH3HW_1DgFWRjW055iW2GFYPyV7vs60yXfoCbkS2bZA83DG1Cb4dBuC$. You are receiving this because you were mentioned.Message ID: @.***>

rpwagner commented 2 years ago

There's now a working build that I was able to test locally. @byee4 when you get a chance, can you do a build from this branch and tag it hub-2.2.2 in Docker Hub? Then later today I'll snapshot the hub instance and try and upgrade JupyterHub. It should be a quick a quick test and we can roll back if it doesn't work.

byee4 commented 2 years ago

@rpwagner Pushed! https://hub.docker.com/repository/docker/brianyee/spatial-tx

rpwagner commented 2 years ago

Excellent, I'll start the update test. The hub will restart in about 30 minutes. I won't spend too long if something goes wrong, I'm sure you're in the middle of getting things going. The Globus server will still be up so you can keep moving things that way.

rpwagner commented 2 years ago

Hub is running at version 2.2.2. I tested Bento and got the same results. The notebook is in the shared-data folder if you want to run it. It's good at loading the CPUs.

Right now, the config pulls the hub-2.2.2 tag. We can set the back to latest when you've tested and want to stick with this build.

rpwagner commented 2 years ago

@byee4 the test image option is now on the hub, which will use brianyee/spatial-tx:latest. I'd say let's merge this PR since it's now the "stable" version. Then you can try out updates by pushing to the latest tag.

Screen Shot 2022-06-30 at 12 18 09 PM