YeoLab / flotilla

Reproducible machine learning analysis of gene expression and alternative splicing data
http://yeolab.github.io/flotilla/docs
BSD 3-Clause "New" or "Revised" License
121 stars 26 forks source link

PCA legend does not respect study.phenotype_order #102

Open boyko- opened 10 years ago

boyko- commented 10 years ago

study.phenotype_order correctly sets the order of phenotypes on the violin plots, but not on the PCA legend. There are two ways to fix that:

1) PREFERRED: permute the colors on the PCA according to phenotype_order and order the phenotype labels in the PCA legend according to the same order. No need to change violin plots.

2) keep the colors and order of the PCA legend and permute the colors on the violin plot, while keeping their order consistent with study.phenotype_order

olgabot commented 10 years ago

Can you share a part of the datapackage you're using? It seems to be a bug in the coloring, not of the PCA legend.

olgabot commented 10 years ago

Example figure: https://github.com/YeoLab/flotilla/issues/111#issuecomment-57742680

mlovci commented 10 years ago

ok, now the pca legend is set correctly and the violin color order is right, but the violin label order is wrong, is that correct, @boyko- ?

olgabot commented 10 years ago

ping @boyko-