Closed alaindomissy closed 8 years ago
Oh wow I'm looking again and I didn't realize that future works for python2 as well. In the past I've used the "six" module. Is that not necessary?
On Tue, Apr 26, 2016 at 11:53 AM Alain Domissy notifications@github.com wrote:
Preliminary work for python2 and python3 compatibility.
Still need to resolve unicode issues with datapackage save functions.
You can view, comment on, or merge this pull request online at:
https://github.com/YeoLab/flotilla/pull/331 Commit Summary
- python and 3 compatibility, renamed test files, added tests
- python2 and python3 compatibility
File Changes
- M TODO.md https://github.com/YeoLab/flotilla/pull/331/files#diff-0 (3)
- M flotilla/init.py https://github.com/YeoLab/flotilla/pull/331/files#diff-1 (25)
- M flotilla/compute/init.py https://github.com/YeoLab/flotilla/pull/331/files#diff-2 (4)
- M flotilla/compute/decomposition.py https://github.com/YeoLab/flotilla/pull/331/files#diff-3 (8)
- M flotilla/compute/expression.py https://github.com/YeoLab/flotilla/pull/331/files#diff-4 (9)
- M flotilla/compute/generic.py https://github.com/YeoLab/flotilla/pull/331/files#diff-5 (7)
- M flotilla/compute/infotheory.py https://github.com/YeoLab/flotilla/pull/331/files#diff-6 (3)
- M flotilla/compute/network.py https://github.com/YeoLab/flotilla/pull/331/files#diff-7 (3)
- M flotilla/compute/outlier.py https://github.com/YeoLab/flotilla/pull/331/files#diff-8 (8)
- M flotilla/compute/predict.py https://github.com/YeoLab/flotilla/pull/331/files#diff-9 (4)
- M flotilla/compute/splicing.py https://github.com/YeoLab/flotilla/pull/331/files#diff-10 (3)
- M flotilla/data_model/init.py https://github.com/YeoLab/flotilla/pull/331/files#diff-11 (4)
- M flotilla/data_model/base.py https://github.com/YeoLab/flotilla/pull/331/files#diff-12 (9)
- M flotilla/data_model/expression.py https://github.com/YeoLab/flotilla/pull/331/files#diff-13 (4)
- M flotilla/data_model/gene_ontology.py https://github.com/YeoLab/flotilla/pull/331/files#diff-14 (22)
- M flotilla/data_model/metadata.py https://github.com/YeoLab/flotilla/pull/331/files#diff-15 (67)
- M flotilla/data_model/quality_control.py https://github.com/YeoLab/flotilla/pull/331/files#diff-16 (7)
- M flotilla/data_model/splicing.py https://github.com/YeoLab/flotilla/pull/331/files#diff-17 (7)
- M flotilla/data_model/supplemental.py https://github.com/YeoLab/flotilla/pull/331/files#diff-18 (6)
- M flotilla/datapackage.py https://github.com/YeoLab/flotilla/pull/331/files#diff-19 (36)
- M flotilla/external/combat.py https://github.com/YeoLab/flotilla/pull/331/files#diff-20 (43)
- M flotilla/study.py https://github.com/YeoLab/flotilla/pull/331/files#diff-21 (16)
- R flotilla/test/compute/test_compute_decomposition.py https://github.com/YeoLab/flotilla/pull/331/files#diff-22 (13)
- A flotilla/test/compute/test_compute_expression.py https://github.com/YeoLab/flotilla/pull/331/files#diff-23 (14)
- A flotilla/test/compute/test_compute_generic.py https://github.com/YeoLab/flotilla/pull/331/files#diff-24 (58)
- R flotilla/test/compute/test_compute_infotheory.py https://github.com/YeoLab/flotilla/pull/331/files#diff-25 (3)
- R flotilla/test/compute/test_compute_network.py https://github.com/YeoLab/flotilla/pull/331/files#diff-26 (3)
- A flotilla/test/compute/test_compute_outlier.py https://github.com/YeoLab/flotilla/pull/331/files#diff-27 (6)
- A flotilla/test/compute/test_compute_predict.py https://github.com/YeoLab/flotilla/pull/331/files#diff-28 (46)
- R flotilla/test/compute/test_compute_splicing.py https://github.com/YeoLab/flotilla/pull/331/files#diff-29 (9)
- M flotilla/test/conftest.py https://github.com/YeoLab/flotilla/pull/331/files#diff-30 (43)
- R flotilla/test/data_model/test_data_model_base.py https://github.com/YeoLab/flotilla/pull/331/files#diff-31 (102)
- R flotilla/test/data_model/test_data_model_expression.py https://github.com/YeoLab/flotilla/pull/331/files#diff-32 (3)
- R flotilla/test/data_model/test_data_model_gene_ontology.py https://github.com/YeoLab/flotilla/pull/331/files#diff-33 (79)
- R flotilla/test/data_model/test_data_model_metadata.py https://github.com/YeoLab/flotilla/pull/331/files#diff-34 (27)
- R flotilla/test/data_model/test_data_model_quality_control.py https://github.com/YeoLab/flotilla/pull/331/files#diff-35 (3)
- R flotilla/test/data_model/test_data_model_splicing.py https://github.com/YeoLab/flotilla/pull/331/files#diff-36 (8)
- A flotilla/test/data_model/test_data_model_supplemental.py https://github.com/YeoLab/flotilla/pull/331/files#diff-37 (6)
- A flotilla/test/test_datapackage.py https://github.com/YeoLab/flotilla/pull/331/files#diff-38 (26)
- M flotilla/test/test_embark.py https://github.com/YeoLab/flotilla/pull/331/files#diff-39 (8)
- M flotilla/test/test_ipython_notebook.ipynb https://github.com/YeoLab/flotilla/pull/331/files#diff-40 (2691)
- A flotilla/test/test_ipython_notebook_jupyter-v3.ipynb https://github.com/YeoLab/flotilla/pull/331/files#diff-41 (1359)
- M flotilla/test/test_study.py https://github.com/YeoLab/flotilla/pull/331/files#diff-42 (286)
- M flotilla/test/test_util.py https://github.com/YeoLab/flotilla/pull/331/files#diff-43 (110)
- D flotilla/test/visualize/test_genericviz.py https://github.com/YeoLab/flotilla/pull/331/files#diff-44 (0)
- A flotilla/test/visualize/test_visualize_color.py https://github.com/YeoLab/flotilla/pull/331/files#diff-45 (23)
- R flotilla/test/visualize/test_visualize_decomposition.py https://github.com/YeoLab/flotilla/pull/331/files#diff-46 (34)
- A flotilla/test/visualize/test_visualize_expression.py https://github.com/YeoLab/flotilla/pull/331/files#diff-47 (6)
- A flotilla/test/visualize/test_visualize_gene_ontology.py https://github.com/YeoLab/flotilla/pull/331/files#diff-48 (6)
- A flotilla/test/visualize/test_visualize_generic.py https://github.com/YeoLab/flotilla/pull/331/files#diff-49 (18)
- A flotilla/test/visualize/test_visualize_ipython_interact.py https://github.com/YeoLab/flotilla/pull/331/files#diff-50 (6)
- A flotilla/test/visualize/test_visualize_network.py https://github.com/YeoLab/flotilla/pull/331/files#diff-51 (6)
- A flotilla/test/visualize/test_visualize_predict.py https://github.com/YeoLab/flotilla/pull/331/files#diff-52 (14)
- A flotilla/test/visualize/test_visualize_splicing.py https://github.com/YeoLab/flotilla/pull/331/files#diff-53 (18)
- M flotilla/util.py https://github.com/YeoLab/flotilla/pull/331/files#diff-54 (18)
- M flotilla/visualize/init.py https://github.com/YeoLab/flotilla/pull/331/files#diff-55 (4)
- M flotilla/visualize/color.py https://github.com/YeoLab/flotilla/pull/331/files#diff-56 (37)
- M flotilla/visualize/decomposition.py https://github.com/YeoLab/flotilla/pull/331/files#diff-57 (25)
- M flotilla/visualize/expression.py https://github.com/YeoLab/flotilla/pull/331/files#diff-58 (7)
- M flotilla/visualize/gene_ontology.py https://github.com/YeoLab/flotilla/pull/331/files#diff-59 (7)
- M flotilla/visualize/generic.py https://github.com/YeoLab/flotilla/pull/331/files#diff-60 (7)
- M flotilla/visualize/ipython_interact.py https://github.com/YeoLab/flotilla/pull/331/files#diff-61 (9)
- M flotilla/visualize/network.py https://github.com/YeoLab/flotilla/pull/331/files#diff-62 (3)
- M flotilla/visualize/predict.py https://github.com/YeoLab/flotilla/pull/331/files#diff-63 (4)
- M flotilla/visualize/splicing.py https://github.com/YeoLab/flotilla/pull/331/files#diff-64 (10)
- M requirements.txt https://github.com/YeoLab/flotilla/pull/331/files#diff-65 (38)
- M setup.py https://github.com/YeoLab/flotilla/pull/331/files#diff-66 (7)
Patch Links:
— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/YeoLab/flotilla/pull/331
While you're at it, can you replace the "print" statements with sys.stdout.write instead?
On Tue, Apr 26, 2016 at 11:55 AM Olga Botvinnik obotvinn@ucsd.edu wrote:
Oh wow I'm looking again and I didn't realize that future works for python2 as well. In the past I've used the "six" module. Is that not necessary?
On Tue, Apr 26, 2016 at 11:53 AM Alain Domissy notifications@github.com wrote:
Preliminary work for python2 and python3 compatibility.
Still need to resolve unicode issues with datapackage save functions.
You can view, comment on, or merge this pull request online at:
https://github.com/YeoLab/flotilla/pull/331 Commit Summary
- python and 3 compatibility, renamed test files, added tests
- python2 and python3 compatibility
File Changes
- M TODO.md https://github.com/YeoLab/flotilla/pull/331/files#diff-0 (3)
- M flotilla/init.py https://github.com/YeoLab/flotilla/pull/331/files#diff-1 (25)
- M flotilla/compute/init.py https://github.com/YeoLab/flotilla/pull/331/files#diff-2 (4)
- M flotilla/compute/decomposition.py https://github.com/YeoLab/flotilla/pull/331/files#diff-3 (8)
- M flotilla/compute/expression.py https://github.com/YeoLab/flotilla/pull/331/files#diff-4 (9)
- M flotilla/compute/generic.py https://github.com/YeoLab/flotilla/pull/331/files#diff-5 (7)
- M flotilla/compute/infotheory.py https://github.com/YeoLab/flotilla/pull/331/files#diff-6 (3)
- M flotilla/compute/network.py https://github.com/YeoLab/flotilla/pull/331/files#diff-7 (3)
- M flotilla/compute/outlier.py https://github.com/YeoLab/flotilla/pull/331/files#diff-8 (8)
- M flotilla/compute/predict.py https://github.com/YeoLab/flotilla/pull/331/files#diff-9 (4)
- M flotilla/compute/splicing.py https://github.com/YeoLab/flotilla/pull/331/files#diff-10 (3)
- M flotilla/data_model/init.py https://github.com/YeoLab/flotilla/pull/331/files#diff-11 (4)
- M flotilla/data_model/base.py https://github.com/YeoLab/flotilla/pull/331/files#diff-12 (9)
- M flotilla/data_model/expression.py https://github.com/YeoLab/flotilla/pull/331/files#diff-13 (4)
- M flotilla/data_model/gene_ontology.py https://github.com/YeoLab/flotilla/pull/331/files#diff-14 (22)
- M flotilla/data_model/metadata.py https://github.com/YeoLab/flotilla/pull/331/files#diff-15 (67)
- M flotilla/data_model/quality_control.py https://github.com/YeoLab/flotilla/pull/331/files#diff-16 (7)
- M flotilla/data_model/splicing.py https://github.com/YeoLab/flotilla/pull/331/files#diff-17 (7)
- M flotilla/data_model/supplemental.py https://github.com/YeoLab/flotilla/pull/331/files#diff-18 (6)
- M flotilla/datapackage.py https://github.com/YeoLab/flotilla/pull/331/files#diff-19 (36)
- M flotilla/external/combat.py https://github.com/YeoLab/flotilla/pull/331/files#diff-20 (43)
- M flotilla/study.py https://github.com/YeoLab/flotilla/pull/331/files#diff-21 (16)
- R flotilla/test/compute/test_compute_decomposition.py https://github.com/YeoLab/flotilla/pull/331/files#diff-22 (13)
- A flotilla/test/compute/test_compute_expression.py https://github.com/YeoLab/flotilla/pull/331/files#diff-23 (14)
- A flotilla/test/compute/test_compute_generic.py https://github.com/YeoLab/flotilla/pull/331/files#diff-24 (58)
- R flotilla/test/compute/test_compute_infotheory.py https://github.com/YeoLab/flotilla/pull/331/files#diff-25 (3)
- R flotilla/test/compute/test_compute_network.py https://github.com/YeoLab/flotilla/pull/331/files#diff-26 (3)
- A flotilla/test/compute/test_compute_outlier.py https://github.com/YeoLab/flotilla/pull/331/files#diff-27 (6)
- A flotilla/test/compute/test_compute_predict.py https://github.com/YeoLab/flotilla/pull/331/files#diff-28 (46)
- R flotilla/test/compute/test_compute_splicing.py https://github.com/YeoLab/flotilla/pull/331/files#diff-29 (9)
- M flotilla/test/conftest.py https://github.com/YeoLab/flotilla/pull/331/files#diff-30 (43)
- R flotilla/test/data_model/test_data_model_base.py https://github.com/YeoLab/flotilla/pull/331/files#diff-31 (102)
- R flotilla/test/data_model/test_data_model_expression.py https://github.com/YeoLab/flotilla/pull/331/files#diff-32 (3)
- R flotilla/test/data_model/test_data_model_gene_ontology.py https://github.com/YeoLab/flotilla/pull/331/files#diff-33 (79)
- R flotilla/test/data_model/test_data_model_metadata.py https://github.com/YeoLab/flotilla/pull/331/files#diff-34 (27)
- R flotilla/test/data_model/test_data_model_quality_control.py https://github.com/YeoLab/flotilla/pull/331/files#diff-35 (3)
- R flotilla/test/data_model/test_data_model_splicing.py https://github.com/YeoLab/flotilla/pull/331/files#diff-36 (8)
- A flotilla/test/data_model/test_data_model_supplemental.py https://github.com/YeoLab/flotilla/pull/331/files#diff-37 (6)
- A flotilla/test/test_datapackage.py https://github.com/YeoLab/flotilla/pull/331/files#diff-38 (26)
- M flotilla/test/test_embark.py https://github.com/YeoLab/flotilla/pull/331/files#diff-39 (8)
- M flotilla/test/test_ipython_notebook.ipynb https://github.com/YeoLab/flotilla/pull/331/files#diff-40 (2691)
- A flotilla/test/test_ipython_notebook_jupyter-v3.ipynb https://github.com/YeoLab/flotilla/pull/331/files#diff-41 (1359)
- M flotilla/test/test_study.py https://github.com/YeoLab/flotilla/pull/331/files#diff-42 (286)
- M flotilla/test/test_util.py https://github.com/YeoLab/flotilla/pull/331/files#diff-43 (110)
- D flotilla/test/visualize/test_genericviz.py https://github.com/YeoLab/flotilla/pull/331/files#diff-44 (0)
- A flotilla/test/visualize/test_visualize_color.py https://github.com/YeoLab/flotilla/pull/331/files#diff-45 (23)
- R flotilla/test/visualize/test_visualize_decomposition.py https://github.com/YeoLab/flotilla/pull/331/files#diff-46 (34)
- A flotilla/test/visualize/test_visualize_expression.py https://github.com/YeoLab/flotilla/pull/331/files#diff-47 (6)
- A flotilla/test/visualize/test_visualize_gene_ontology.py https://github.com/YeoLab/flotilla/pull/331/files#diff-48 (6)
- A flotilla/test/visualize/test_visualize_generic.py https://github.com/YeoLab/flotilla/pull/331/files#diff-49 (18)
- A flotilla/test/visualize/test_visualize_ipython_interact.py https://github.com/YeoLab/flotilla/pull/331/files#diff-50 (6)
- A flotilla/test/visualize/test_visualize_network.py https://github.com/YeoLab/flotilla/pull/331/files#diff-51 (6)
- A flotilla/test/visualize/test_visualize_predict.py https://github.com/YeoLab/flotilla/pull/331/files#diff-52 (14)
- A flotilla/test/visualize/test_visualize_splicing.py https://github.com/YeoLab/flotilla/pull/331/files#diff-53 (18)
- M flotilla/util.py https://github.com/YeoLab/flotilla/pull/331/files#diff-54 (18)
- M flotilla/visualize/init.py https://github.com/YeoLab/flotilla/pull/331/files#diff-55 (4)
- M flotilla/visualize/color.py https://github.com/YeoLab/flotilla/pull/331/files#diff-56 (37)
- M flotilla/visualize/decomposition.py https://github.com/YeoLab/flotilla/pull/331/files#diff-57 (25)
- M flotilla/visualize/expression.py https://github.com/YeoLab/flotilla/pull/331/files#diff-58 (7)
- M flotilla/visualize/gene_ontology.py https://github.com/YeoLab/flotilla/pull/331/files#diff-59 (7)
- M flotilla/visualize/generic.py https://github.com/YeoLab/flotilla/pull/331/files#diff-60 (7)
- M flotilla/visualize/ipython_interact.py https://github.com/YeoLab/flotilla/pull/331/files#diff-61 (9)
- M flotilla/visualize/network.py https://github.com/YeoLab/flotilla/pull/331/files#diff-62 (3)
- M flotilla/visualize/predict.py https://github.com/YeoLab/flotilla/pull/331/files#diff-63 (4)
- M flotilla/visualize/splicing.py https://github.com/YeoLab/flotilla/pull/331/files#diff-64 (10)
- M requirements.txt https://github.com/YeoLab/flotilla/pull/331/files#diff-65 (38)
- M setup.py https://github.com/YeoLab/flotilla/pull/331/files#diff-66 (7)
Patch Links:
— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/YeoLab/flotilla/pull/331
Preliminary work for python2 and python3 compatibility. Not ready to merge. Still need to resolve unicode issues with datapackage save functions.