Yep-Was-Taken / pupBuddy

0 stars 3 forks source link

Code review changes #21

Closed MSG17 closed 2 years ago

MSG17 commented 2 years ago

This is my code review pull request. I added my rationale to each change through inline Github comments. I aimed to make the project more complete and standardized as well as introduce test-driven design.

discospiff commented 2 years ago

Several good suggestions that reduce technical debt. I recommend merging this branch.

MSG17 commented 2 years ago

Adding some comments: What does the program do? This program allows users to keep track of their pets and tasks they need to do to care for them through a web interface. Users can log in and see what tasks they need to do and what tasks have already been completed, as well as assign responsibilities to members of their household. Was the program available on time? Yes, I was able to pull, run and review it on time. Does the program compile? Yes, but the web interface only displays an error page when run. What did you learn from this code review? I learned several concepts from this exercise: