Phase tracking error causes the server to crash

[treyzania]

I'm fairly sure that this is only happening when I have this plugin installed. I'm using a version built from source ec97ade. I was previously using the version published on Ore and was getting similar state issues.

Gist: https://gist.github.com/treyzania/6227f2c74e627d912be33a0c644400ef And another crash log too big for gist (scroll to the end): https://tr3y.io/media/2018-05-15-7.log

I'm also getting a lot of "can't keep up" warnings that only happen with this plugin. I'm running this on a reasonably powerful DigitalOcean droplet so I don't think that I'm actually underprovisioning the server. I'm trying to run the timings to check to be sure if this is actually the case.

This is in the log but I'll copy it here for ease of reference:

Minecraft: 1.12.2
SpongeAPI: 7.1.0-SNAPSHOT-7d8a9382
SpongeVanilla: 1.12.2-7.1.0-BETA-42

[treyzania]

I also occasionally get this warning in the console, which doesn't crash the server:

[22:20:42 ERROR] [AntiXray]: Failed to bind a container of a network chunk
java.lang.UnsupportedOperationException: null
        at net.smoofyuniverse.antixray.impl.network.NetworkChunk.setContainer(NetworkChunk.java:144) ~[NetworkChunk.class:?]
        at net.smoofyuniverse.antixray.impl.network.NetworkChunk.setContainer(NetworkChunk.java:138) ~[NetworkChunk.class:?]
        at net.minecraft.world.chunk.Chunk.bindContainer(SourceFile:4946) ~[axw.class:?]
        at net.minecraft.world.chunk.Chunk.bindContainerSafely(SourceFile:4956) ~[axw.class:?]
        at net.minecraft.world.chunk.Chunk.handler$onSetLightFor$zpi000(SourceFile:4981) ~[axw.class:?]
        at net.minecraft.world.chunk.Chunk.func_177431_a(SourceFile:550) ~[axw.class:?]
        at net.minecraft.world.WorldServer.setLightForAsync(SourceFile:4017) ~[oo.class:?]
        at net.minecraft.world.WorldServer.checkLightAsync(SourceFile:3812) ~[oo.class:?]
        at net.minecraft.world.WorldServer.updateLightAsync(SourceFile:3921) ~[oo.class:?]
        at net.minecraft.world.chunk.Chunk.checkWorldLightFor(SourceFile:4706) ~[axw.class:?]
        at net.minecraft.world.chunk.Chunk.redirect$onCheckLightForSkylightNeighbor$zoh000(SourceFile:4221) ~[axw.class:?]
        at net.minecraft.world.chunk.Chunk.func_76609_d(SourceFile:268) ~[axw.class:?]
        at net.minecraft.world.chunk.Chunk.relightBlockAsync(SourceFile:4652) ~[axw.class:?]
        at net.minecraft.world.chunk.Chunk.lambda$onRelightBlock$3(SourceFile:4538) ~[axw.class:?]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_171]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_171]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_171]

[Yeregorix]

I need to reproduce the error on my computer to fix the issue. Can you send me a minimal server setup which is affected by this issue ?

[treyzania]

Here's a zip that should reproduce the issue, using the 1.2.7. release: https://tr3y.io/media/antixray-example.zip

You can start the server with harness.sh. I also included the crash-reports folder from Sponge, which has some crash logs from when I was initially testing the server, so the ones you would be looking for would be the more recent ones.

Thanks!

[Yeregorix]

About your crash, I did not found anything related to my plugin for now, these kind of crashes are very generics and can be caused by almost anything. Keep me informed if this crash reappear. About your performances issues, try to run some timings (10 minutes are usually enough but longer is better) and then post the timings link here or in private. Can you also give me a copy of your worlds configurations ?

[Yeregorix]

This issue was probably fixed during the numerous modifications of the last version. I close this issue as long as it does not reappear.