search

Yermo / geoPHPwithFeatures

Advanced geometry operations in PHP with Features Data
Other
5 stars 4 forks source link

Fix GPX export, omitting unkown types, refactoring #19

Closed amenk closed 6 years ago

amenk commented 6 years ago

(needs PHP7)

Closes #18

amenk commented 6 years ago

here you go, I hope you do not mind about supporting only php7

Yermo commented 6 years ago

Unfortunately, I'm stuck running hhvm for the foreseeable future so requiring PHP7 is not going to work for me. I will eventually make the switch but it's probably going to be much later this year.

Any chance you can make it PHP 5.6 compatible?

amenk commented 6 years ago

Sure, I realized anyways that the project I want to use this, is still running PHP5.5 :grinning:

Yermo commented 6 years ago

It's interesting that the tests pass with hhvm but fail with PHP7 with a redeclaration of getPrecedence() error. 

PHP Fatal error:  Cannot redeclare getPrecedence() (previously declared in /usr/local/YML/WWW/miles-by-motorcycle.com/html/formvista/fvtk/src/3rdparty/geoPHPwithFeatures/lib/adapters/GPX.class.php:1072) in /usr/local/YML/WWW/miles-by-motorcycle.com/html/formvista/fvtk/src/3rdparty/geoPHPwithFeatures/lib/adapters/GPX.class.php on line 1072
yml@cylon:/usr/local/WWW/miles-by-motorcycle.com/html/formvista/fvtk/src/3rdparty/geoPHPwithFeatures/tests$ gvim ../lib/adapters/GPX.class.php

While I don't want to require PHP7 support, where possible I'd like it to run with both.

Yermo commented 6 years ago

Thanks for fix.