search

YesIKnowIT / Blog

Article published on https://yesik.it
2 stars 1 forks source link

Escape HTML code properly #2

Closed sskras closed 2 years ago

sskras commented 2 years ago

Also fix the <sub> tag.

s-leroux commented 2 years ago

Thanks, Saulius. Good catch!

I should have used the proper Asciidoctor syntax for superscript: https://docs.asciidoctor.org/asciidoc/latest/text/subscript-and-superscript/

Could you update your PR to replace <sup>2</sup> by ^2^ ?

sskras commented 2 years ago

Thanks for reminding me about this Asciidoc ability, I used your tip.

I did a forced push onto the same branch. Not sure about where the final commit message would come from.

s-leroux commented 2 years ago

Thanks. I will merge that this weekend

I will also add a 'contributors' or alike new header at the top of the document

s-leroux commented 2 years ago

@sskras: I merged the PR and then added your name as a contributor in the article header.

sskras commented 2 years ago

Oh, thanks!