search

Yesssssman / epicfightmod

Other
155 stars 96 forks source link

Still being able to attack when downed with PlayerRevive mod #1090

Closed ricchix closed 2 months ago

ricchix commented 2 years ago

https://user-images.githubusercontent.com/89796563/180392992-684ca118-6413-44a4-b12f-f408a2fac6d2.mp4

This is on 1.18.2 and Forge 40.1.68 EpicFight version: 18.2.6-beta PlayerRevive version: 2.0.1

CreativeMD commented 2 years ago

PlayerRevive cancels the ClickInputEvent when a player is downed (source). So somehow this is being ignored.

adoetho commented 6 months ago

Any updates to this?

Jetpack-Cat commented 3 months ago

Any update on this? I really need player revive for my modpack.

Walrus98 commented 3 months ago

Can you maybe inject some of your code using mixin? Maybe we can handle that, disabling the damage event overriding attack entity method of this class https://github.com/Yesssssman/epicfightmod/blob/a55c570a9675c25bc1eaf5f97146c91e36c2c161/src/main/java/yesman/epicfight/events/PlayerEvents.java#L33

CreativeMD commented 3 months ago

@Walrus98 sorry but I will not mixin into other peoples code just to get the compatibility solved. Already provided a suggestion for the solution.

MetalKnight56 commented 3 months ago

Issue has been solved on our side and will be made available in a future update.