search

Yesssssman / epicfightmod

Other
155 stars 96 forks source link

Slight incompatibility with cosmetic armor reworked (Low Priority) #644

Closed Coach-mdl closed 2 years ago

Coach-mdl commented 3 years ago

Armor equipped in vanity slots does not show up in first person during combat mode. Instead the armor you are wearing in your regular armor slots will render.

Yesssssman commented 3 years ago

Sorry, but it can't be fixed since it's out of my boundary. (code)

gaesyeah commented 3 years ago

Hi. @Coach-mdl maybe you can try to talk about this with the devs of the "cosmetic armor reworked".

https://github.com/Yesssssman/epicfightmod/issues/536 this link have a "guide" to help with, just click on "Guideline" in the end.

Yesssssman commented 3 years ago

@gaesyeah They don't use the custom armor but they made their own slot to show a vanity armor. There's no way to recognize the vanity slot for Epic Fight, so it's hard to make compatible.

gaesyeah commented 3 years ago

oh i got it, have sense. Thanks.

zlainsama commented 3 years ago

my mod works by replacing items right before rendering a player and restoring them after. (it uses RenderPlayerEvent.Pre and RenderPlayerEvent.Post) if your renderer could implement these render events, then compatibility should be able to achieve. otherwise, if you could provide a special render event similarly for your renderer, I can add compatibility code on my side.

gaesyeah commented 3 years ago

Hi, thanks @zlainsama, but @Yesssssman apparently is only going to come back in October 27th due to personal reasons: https://github.com/Yesssssman/epicfightmod/issues/662

Maybe this "bug" can be solved in the near future. Thanks!

Yesssssman commented 3 years ago

@zlainsama Hello, I have a question about how to access your code. Since I'm a beginner at modding, I thought I had to add a dependency to access your code. But in this case, I think that people need to install your mod to run Epic Fight. But If I misunderstood, Is there any way to detect if your mod is installed in runtime? so that it doesn't have to run the code that checks the vanity slot if your mod is not installed.

zlainsama commented 3 years ago

In Forge, you can use this to check if my mod is installed in runtime: ModList.get().isLoaded("cosmeticarmorreworked")

Yesssssman commented 3 years ago

@zlainsama Ok, thanks! I'll fix this problem after I come back.

zlainsama commented 2 years ago

@Yesssssman I finally played EpicFight myself, and I know the problem now, I will release a fix in 1.16.5 and 1.17.1 on my end.

Yesssssman commented 2 years ago

Oh, I nearly forgot about this issue... sorry and thanks for your time.

Yesssssman commented 2 years ago

Actually, In my last attempt, I failed to build the project that was dependent on your mod.