search

Yet-Zio / yetCalc

Yet another calculator designed and developed for Android
BSD 3-Clause "New" or "Revised" License
209 stars 16 forks source link

System buttons bar have white on white buttons + buttons cutoff at bottom[possibly screen size] #113

Open Porkepix opened 6 months ago

Porkepix commented 6 months ago

System buttons bar have white on white buttons which are barely visible. Device runs Android Oreo (8.0) stock. See screenshot below.

Screenshot ![Screenshot_20240313-120427](https://github.com/Yet-Zio/yetCalc/assets/709500/60be3376-12da-45e4-a057-96839114c264)
Yet-Zio commented 6 months ago

@Porkepix what's your screen size?

Porkepix commented 6 months ago

5.2", but that have no link to the colors in this bar?

Yet-Zio commented 6 months ago

Hmm Screenshot_20240313-182626 In this device, the light theme doesn't have that issue, on Android 11. But that doesn't matter, I haven't done anything to modify the navigator bar button color itself only the background color, don't know why your device interprets it that way.

Also you made another issue concerning buttons cutting off as your navigation bar takes space. This is apparently due to screen size as I haven't optimized it for lower sizes, I might implement a scroll later.

Porkepix commented 6 months ago

Also you made another issue concerning buttons cutting off as your navigation bar takes space. This is apparently due to screen size as I haven't optimized it for lower sizes, I might implement a scroll later.

Screen size never should matter I think. Display resolution should. But it's a FHD (1920x1080) display, which is by now mean low.

From what I can understand, older Android versions might need some work these places, I've seen other projects needing to adjust styling things to fix this.

Yet-Zio commented 6 months ago

@Porkepix About your navigation bar buttons getting white with the background, that's really weird, this is unrelated to screen size or theme and I have never seen that occuring.

Porkepix commented 6 months ago

@Porkepix About your navigation bar buttons getting white with the background, that's really weird, this is unrelated to screen size or theme and I have never seen that occuring.

I've seen this many times in different applications (not all of them). Some of them fixed it, others didn't. Sometimes it depends on the framework or other imported pieces of software. Sometimes it affect only either ones of light or dark themes, sometimes both.

I'm not developer, even less for Android, but every time Google decided to go through major visual revamps on Android, it came with quite some breakages and needs for developers to adjust specific things for those as code done for more recent versions of Android seemed to have some hard time be backward-compatible on those aspects.