search

YetAnotherPomodoroApp / YAPA-2

Minimalistic desktop timer app for Pomodoro Technique users
https://yapa2.app/
MIT License
518 stars 57 forks source link

Work time setting - 'Up arrow' decreases values? #21

Closed Gennady-G closed 7 years ago

Gennady-G commented 7 years ago

Hi!

2017-09-05_224617

YAPA 2.0.80

Usually "Up arrow" key increases value, but "down" decreases. But in Yapa it works vice versa. I often change intervals and there is a little confusion.

floatas commented 7 years ago

Hi, items in dropdown are in ascending order, yeah it probably makes more sense to reverse list. Then up arrow would increase.

Why do you change interval lengths? Maybe there's something that can be done in app to help ?

floatas commented 7 years ago

Closed automatically on commit, reopening for now.

Gennady-G commented 7 years ago

Hi!

Hi, items in dropdown are in ascending order

Yes, a little non-intuitively in my opinion..

Why do you change interval lengths? Maybe there's something that can be done in app to help ?

Don't think. I sometimes restart pc and then begin from last time. I also sometimes closed/reopened Yapa 1, becouse I had feeling that it begins to slow my machine after few hours (I work on low-performance laptop now). Don't know, it is only assumption.. Now I use Yapa 2 and works better.

But maybe some research about performance is good idea.. There is a small hang when interval ends. Maybe related with animation, or with sound.. Also opening menu (by right click) sometimes takes few seconds for me.

upd.: Checked now and it works fast)

I understand that performance issues is hard to catch, and I have no bug reports now. I will pay attention and keep You posted

floatas commented 7 years ago

Don't think. I sometimes restart pc and then begin from last time.

Well, I have some good news. Next release will remember and will ask if you want to continue unfinished pomodoro. If you start pomodoro -> close app -> reopen app, it will ask if you want to continue from where you left before. This is already implemented, need to do a bit more testing.

Also opening menu (by right click) sometimes takes few seconds for me.

I also noticed that, doesn't happen very often for me. I think it's related to dashboard.

Maybe related with animation, or with sound

Animation do cause some performance issues, there is setting to disable animations. When animations are disabled then solid color is displayed.

Will do some performance debugging (Visual Studio has some nice tools for that) and hopefully will make next release on weekend.

Gennady-G commented 7 years ago

Well, I have some good news. Next release will remember and will ask if you want to continue unfinished pomodoro. If you start pomodoro -> close app -> reopen app, it will ask if you want to continue from where you left before. This is already implemented, need to do a bit more testing.

Oh, that's great! Will it support restart, for example if I use this command to restart server: shutdown /r /t 30 ? Maybe You can add this 'autosave' to 'OnApplicationClose' event, or something similar (not sure what You use)? If so, then imho You can remove "Are You sure You want to exit and close pomodoro" confirmation window. Yapa will always know last position

Animation do cause some performance issues, there is setting to disable animations.

Ah Yes, I already use it. Maybe that's why I say 'it works better now' :).

Will do some performance debugging

I have suspicion that performance issue occurs after some hours of work. Maybe there is some small leak.. But not sure

Best regards,
Gennady

Gennady-G commented 7 years ago

I can create separate bug for performance researches, if needed

floatas commented 7 years ago

Oh, that's great! Will it support restart, for example if I use this command to restart server: shutdown /r /t 30

It will support, it uses onclosing event to save. For now commented out message box with close confirmation.

I found few performance issues and fixed them. Settings should open faster and hopefully won't lag after pomodoro work end.

floatas commented 7 years ago

New version released, let me know if there still are performance issues.

Gennady-G commented 7 years ago

Cool! "Up arrows" now increase values, thank You. This bug is fixed

It will support, it uses onclosing event to save. For now commented out message box with close confirmation.

Wow. Great! :)

New version released, let me know if there still are performance issues.

Ok! I will look around

floatas commented 7 years ago

Closing bug since original issue is now fixed :) if there are other issues, please create separate issue.