search

Yetangitu / owncloud-apps

Applications for Nextcloud and Owncloud personal cloud server
GNU Affero General Public License v3.0
86 stars 41 forks source link

Compatibility with Nextcloud 14 #106

Open ChristophWurst opened 6 years ago

ChristophWurst commented 6 years ago

Hi,

as you may have already seen, we have entered the beta phase for the release of Nextcloud 14. We usually try to keep up compatibility with previous app versions, but in some cases apps need some adjustments to properly work on new Nextcloud releases. With Nextcloud 14 there have been quite some changes in that regard:

You can find a list of all critical changes for app developers and admins at https://github.com/nextcloud/server/issues/7827. You can run occ app:check-code to validate that there are no issues with deprecated or private message calls.

One critical change is the overall restructuring of the main template (https://github.com/nextcloud/server/pull/9982) that might require some adjustments in your apps.

We would be very pleased if you can make your apps compatible with Nextcloud 14 and release a new version to the app store, so that users can properly test it and the upgrade experience to Nextcloud 14 will be even better than before.

Feel free to ask, if you have any questions regarding making your app compatible with Nextcloud 14.

Thanks for being part of the Nextcloud community and for all the effort you put into providing your apps :rocket: .

lemmy04 commented 6 years ago

Nextcloud 14 is released by now....

donty commented 6 years ago

Still not able to run under NC 14, is that likely to be fixed? Not sure if it is a big problem or just requires testing/describing it as so in the info file.

aegisgfx commented 6 years ago

This app seems to be dead. Anyone feel like forking it?

e-alfred commented 6 years ago

At least Onlyoffice now supports opening *.epub files. So if somebody is looking for alternatives...

e-alfred commented 6 years ago

Okay, I patched up the files_reader app in this PR: https://github.com/Yetangitu/owncloud-apps/pull/108

It works with NC14+ now, but there might be some problems still.

jpereztenerife commented 6 years ago

Great news e-alfred! So, to be able to use the reader we should pull from the repo and that's it?

melroy89 commented 6 years ago

Steps to reproduce

  1. Upgrade to Nextcloud stable v14.0.1
  2. You will get an internal server error

Expected behaviour

No internal server error.

Actual behaviour

"Error","Message":"Class 'OCP\\Config' notfound",
"Code":0,"Trace":[{"file":"\/var\/www\/nextcloud\/html\/apps\/files_reader\/lib\/Hooks.php",
"line":41,"function":"get","class":"OCA\\Files_Reader\\Config","type":"::","args":["epub_enable","true"]},
{"file":"\/var\/www\/nextcloud\/html\/lib\/private\/legacy\/hook.php","line":106,"function":"announce_settings","class":"OCA\\Files_Reader\\Hooks

Workaround

sudo -u www-data php occ app:disable files_reader

Server configuration

Operating system: Linux (Debian Stretch) Web server: Nginx Database: MySQL PHP version: 7.1 Nextcloud version: (see Nextcloud admin page) 14.0.1

Where did you install Nextcloud from: Official source upgrader

List of activated apps: Your E-book reader...

lemmy04 commented 6 years ago

...the last commit by the author of these apps was in february...

WNYmathGuy commented 5 years ago

At least Onlyoffice now supports opening *.epub files. So if somebody is looking for alternatives...

So @e-alfred do you know if I can simultaneously run OnlyOffice and Collabora's LibreOffice inside one instance of Nextcloud?

I just started helping somebody self-publish and I discovered my Nextcloud couldn't open ePub files.

sehucke commented 5 years ago

There is a PR for files_opds, see #109

e-alfred commented 5 years ago

@WNYmathGuy You can use the Collaboara and Onlyoffice apps on the same Nextcloud instance. Just be careful if you do some collaborative editing no to open it up in both apps at the same time (could lead to data loss).

WNYmathGuy commented 5 years ago

@WNYmathGuy You can use the Collaboara and Onlyoffice apps on the same Nextcloud instance. Just be careful if you do some collaborative editing no to open it up in both apps at the same time (could lead to data loss).

@e-alfred I gave it a whirl. OnlyOffice has cool settings where I can check and uncheck file types, but even when I selected only epub files for it to open, it didn't work. When the admin makes the setting changes and clicks save, an error is thrown. The setting changes are persistent, but epubs are not opened, just downloaded when clicked.