Yetangitu / owncloud-apps

Applications for Nextcloud and Owncloud personal cloud server
GNU Affero General Public License v3.0
86 stars 41 forks source link

Ebook reader crashes Nextcloud 17 #125

Open Wotisrv opened 4 years ago

Wotisrv commented 4 years ago

When I download and enable ebook reader I get the internal error screen.

Removing the files_reader directory fixes the problem.

Nextcloud 17.0.0 Php 7.3.10 Fedora 30 Server Edition

pkostelnik commented 4 years ago

Same here, but just disabling the app with php occ app:disable files_reader returns the nextcloud back to work.

AetherCollective commented 4 years ago

same here

Wotisrv commented 4 years ago

Still present with NC18 and upgraded Fedora server. I have disabled the app via occ command Is there any reason to use this app by the way?

AetherCollective commented 4 years ago

I have books in epub format that try to load external

On Wed, Feb 5, 2020, 12:28 PM Tino Wolf notifications@github.com wrote:

Still present with NC18 and upgraded Fedora server. I have disabled the app via occ command Is there any reason to use this app by the way?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Yetangitu/owncloud-apps/issues/125?email_source=notifications&email_token=ABVT4727C6JIIT426AA5QIDRBLZNBA5CNFSM4JDODJO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK4I6ZI#issuecomment-582520677, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVT4737EJOOM6H3CZZ67A3RBLZNBANCNFSM4JDODJOQ .

SimJoSt commented 4 years ago

I have contacted @Yetangitu about this via email to get an update.

Wotisrv commented 4 years ago

Is there something happening here?

noci2012 commented 4 years ago

The reader still uses OCP\Config which has been removed... I am trying to get a hold of the Nextcloud API and it is not as trivial as things look like. The API documentation is probably correct but hard to get into when it's all new. And not all things described are necessarily the most recent state of things (yet).

Although this is a small fix ... there is a huge difference between the API when the reader was build and the current APIs.. Since V15 old stuff is getting removed ==> breaking things that are not updated. A lot of developpers gave up on rewriting most of their application to accomodate to the new API.. between V11 - V16.

noci2012 commented 4 years ago

try these changes: https://github.com/noci2012/owncloud-apps/tree/noci2012-config-patch

yeupou commented 4 years ago

Same on nextcloud 18.

e-alfred commented 4 years ago

I forked the files_reader app and will publish a new release to the App Store soon:

https://github.com/e-alfred/epubreader

If anybody wants to help me out with development, any contributions are welcome!