Project feedback

[thedarkjester]

At the outset I would like to say that this is an interesting and ambitious project and you have done well to get to where you are.

There are a few things to note:

• The .sol references in your main contract reference local directories, so pulling it down doesn't quite work

  import "/home/joe/Code/blockchain-developer-bootcamp-final-project/interfaces/ILendingPoolAddressesProviderV2.sol";
  import "/home/joe/Code/blockchain-developer-bootcamp-final-project/interfaces/ILendingPoolV2.sol";

• You could use SafeMath for any calculations as it isn't included in Solidity Compilers pre .0.8.0
• The EscapeHatch doesn't quite count as a circuit breaker, as other functions are still executable - a Pause on other methods is the general practive
• The EscapeHatch LINK send is to the caller vs owner - still is valid and the same address, just inconsistent in the code
• You could save gas by packing the state variables better - e.g. grouping all the uint16s first
• You could use a smaller defined ERC20 interface to save gas vs. pulling in the entire interface

I can see where the project is headed and I wish you well.

[jmcook1186]

Hello,

thanks a lot for this feedback - I am pushing some amends in a few minutes. The first point about the references is my oversight as there are copies of each of those imported contracts in the project repository and I neglected to update the references before submitting. Fixed in next commit. Also now see how the escapeHatch function and gas optimisation comments make a lot of sense.

Could you possibly explain the final comment about a smaller erc20 interface in a little more detail?

Thanks again!

[thedarkjester]

My comment on the IERC20.

If you see: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC20/IERC20.sol

There are a few methods you don't use, so don't really need to use the entire interface.

If you declare your own IERC20.sol with just the approve and transfer functions, it should bring down the gas costs. Also, you get to remove the floating pragma on the interface.

[thedarkjester]

The feedback is more for future and your knowledge - don't need to do them now :)

[jmcook1186]

Brilliant, thanks. Yes, np I just like to do these things while they are fresh!