YetiForceCompany / YetiForceCRM

Our team created for you one of the most innovative CRM systems that supports mainly business processes and allows for customization according to your needs. Be ahead of your competition and implement YetiForce!
https://yetiforce.com
Other
1.72k stars 742 forks source link

[bug] Illegal value has been entered for this field type. Field name: tax, Module: FInvoice, Value: 50.388 #11469

Closed mad99 closed 5 years ago

mad99 commented 5 years ago

Hi, I'm searching for a solution to create a «part payment invoice»:

One approach could be to set a «Discount of 66%» to get 34% of the full amount for the first invoice of three in total.

If I fill 66 (%) in the field «Discount» YetiForce calculate all right and also changed the amounts.

But when I click «save» there is an error:

Illegal value has been entered for this field type. Field name: tax, Module: FInvoice, Value: 50.388

Bildschirmfoto 2019-09-11 um 11 04 23

So I guess there is an error/bug in the system, when the discount is bigger than 50.388 I guess.

Hope will help others.

Maybe someone has a hint, how it is possible to create «üart payment invoices» with YetiForce. https://github.com/YetiForceCompany/YetiForceCRM/issues/11467

Regards Martin

davide-alghi commented 5 years ago

Hi Martin, what about your YF version?

You are speaking about discount percentage, but the error is relative to tax ... something I don't understand

mad99 commented 5 years ago

Hey davide-alighi, thank you for the question.

Version YetiForce 5.2.0

Yes, I also don't understand:

Without Discount, there is no error, the PDF will create fine.

Then I click on «set» in the box «Discount»

Sales invoices Edit-Click Discount summary set

All is fine -> then I add 66 (%)

Sales invoices Edit add 66

And press «save»

Sales invoices Edit - discount is calculated

All is fine -> then I click «save» for the invoice:

Sales invoices Edit -click save

And then the error is there:

Bildschirmfoto 2019-09-11 um 11 04 23

I guess the error is wrong «texted». Or something is wrong compound in the code.

I dont no why there is the information about «tax» instead of «discount». But I did only change the «discount».

Maybe the calculation from the tax has some limits and is depending on filed discount...

Hope information will help to solve the problem/bug. Regards Martin

mariuszkrzaczkowski commented 5 years ago

Test this change https://github.com/YetiForceCompany/YetiForceCRM/commit/b91f7b1b92a801f3bd06c66f64050b9bee983031

mad99 commented 5 years ago

Hey mariuszkrzaczkowski

Have wrote a dirty trial_and_error file: backup'd «Validator.php» and changed on the server code direct. There is no Error-Throwing left.

So the bug seams to be fixed in the next update ;o))

Thank you, will leave the «hot-fix» in the Validator.php file.

Regards Martin

hanybmw commented 4 years ago

Hey mariuszkrzaczkowski many thanks