[bug] 12 Hour Clockpicker "Please enter valid time"

[z0lo13]

🐞 bug report

⁉️ Describe the bug

in 5.3 SP 2 as well as gitstable does not allow to save time when using 12 hour format. It is fixed in current git developer but was not coming with a second service pack.

🔥 How to trigger the error

Gitstable

Our Instance

👎 Actual Behavior

Time is not saved

👍 Expected Behavior

Time saved

👷 Testing

• [ ✔️] I confirm that I tested it at https://gitstable.yetiforce.com Not working
• [ ✔️] I confirm that I tested it at https://gitdeveloper.yetiforce.com Working as it should but not included in SP

📷 Screenshot of configuration

Git Stable

📝 PHP/Apache/Nginx/Browser/CRM Logs

Git Stable

🌍 Your Environment

Git Stable | | Service Pack version | 2|

[kcrudup]

The clockpicker is adding an extra space between the AM/PM and the time.

Creating 10:00 AM - extra space - invalid and not 10:00 AM - no extra space - valid

[z0lo13]

@konadrian https://github.com/YetiForceCompany/YetiForceCRM/commit/6e6895d4859509e415bd5c1d909147a2a6aae40e the space on line 899

[acsinsurancegroup]

Been an issue every release as far back as I can remember. No effort has gone into correcting it for 12 hour since it works for those in 24 hours.

[rskrzypczak]

The problem is in the clockpicker library itself, they have a wrongly compiled min.js file in there. You can solve this error quickly in 2 ways:

1. Remove public_html/libraries/clockpicker/dist/bootstrap4-clockpicker.min.js file
2. Disable loading min.js files config/Developer.php ($MINIMIZE_JS)

[acsinsurancegroup]

Wow @rskrzypczak finally someone with a solution for an issue with this system that actually works. Thanks so much man, it worked perfectly. Assuming it doesn't cause issues elsewhere that is lol.

Would you mind helping me out with this other issue that I really need to get working asap? #12793

Thanks again mate!

[rskrzypczak]

install service pack v4