fix for not checking deleted flag in getCrmIdByLabel - Githubissues

YetiForceCompany / YetiForceCRM

Our team created for you one of the most innovative CRM systems that supports mainly business processes and allows for customization according to your needs. Be ahead of your competition and implement YetiForce!

https://yetiforce.com

Other

1.74k stars 749 forks source link

fix for not checking deleted flag in getCrmIdByLabel #17424

Open WMCyn opened 7 months ago

WMCyn commented 7 months ago

missing check for crmentity deleted flag

causing import to match deleted records

Description

added check for deleted flag in crmentity table

Testing

Import a quote that has a product with name that matches a product that has both an older deleted record and a newer on with the same name.

Changes

[ X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

[ X] My code is written according to the guidelines found [here] (https://github.com/php-fig/fig-standards).
[ ] I have signed the Contributor Licence Agreement between me and YetiForce.