search

YevgeniGitin / Angular-Shop-Exercise

0 stars 1 forks source link

Angular Comments #2

Open Ari-Shatunovsky opened 5 years ago

Ari-Shatunovsky commented 5 years ago
  1. Images are still stretched.
  2. Form errors are shown even in pristine state.
  3. Models (nod modules) property names are inconsistent: product - capital letter, and rest with small.
  4. Be consistent in formatting: spaces, lines, etc.
  5. Single quotes instead of double.
  6. You can use string properties for translation instead of if else block. Like translationJson[lang]
  7. Using variables with name like "flag" is bad practice.
  8. Typos in English words like "Categorys instead of Categories".
YevgeniGitin commented 5 years ago

I fixed all the comments, you can see it in the routing exercise.